Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Issue 6691530349740032: issue 1689 - Don't show subscription cancellation text at donation page if credit card donation is … (Closed)

Created:
Jan. 7, 2015, 2:24 p.m. by saroyanm
Modified:
Jan. 7, 2015, 7:10 p.m.
Reviewers:
Thomas Greiner
Visibility:
Public.

Description

This review is related to current ticket: https://issues.adblockplus.org/ticket/1689

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M donate-body.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M donate-head.html View 1 2 2 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 8
saroyanm
Thomas can you please have a look when you will have time.
Jan. 7, 2015, 2:26 p.m. (2015-01-07 14:26:33 UTC) #1
Thomas Greiner
http://codereview.adblockplus.org/6691530349740032/diff/5629499534213120/donate-head.html File donate-head.html (right): http://codereview.adblockplus.org/6691530349740032/diff/5629499534213120/donate-head.html#newcode91 donate-head.html:91: #form.credit-card #recurrent-cancellation I think this should rather be added ...
Jan. 7, 2015, 2:35 p.m. (2015-01-07 14:35:01 UTC) #2
saroyanm
http://codereview.adblockplus.org/6691530349740032/diff/5629499534213120/donate-head.html File donate-head.html (right): http://codereview.adblockplus.org/6691530349740032/diff/5629499534213120/donate-head.html#newcode91 donate-head.html:91: #form.credit-card #recurrent-cancellation On 2015/01/07 14:35:01, Thomas Greiner wrote: > ...
Jan. 7, 2015, 2:44 p.m. (2015-01-07 14:44:49 UTC) #3
Thomas Greiner
http://codereview.adblockplus.org/6691530349740032/diff/5724160613416960/donate-head.html File donate-head.html (right): http://codereview.adblockplus.org/6691530349740032/diff/5724160613416960/donate-head.html#newcode146 donate-head.html:146: #form.credit-card #recurrent-cancellation You can directly merge that selector into ...
Jan. 7, 2015, 4:27 p.m. (2015-01-07 16:27:19 UTC) #4
saroyanm
http://codereview.adblockplus.org/6691530349740032/diff/5724160613416960/donate-head.html File donate-head.html (right): http://codereview.adblockplus.org/6691530349740032/diff/5724160613416960/donate-head.html#newcode146 donate-head.html:146: #form.credit-card #recurrent-cancellation On 2015/01/07 16:27:19, Thomas Greiner wrote: > ...
Jan. 7, 2015, 4:30 p.m. (2015-01-07 16:30:29 UTC) #5
Thomas Greiner
http://codereview.adblockplus.org/6691530349740032/diff/5629499534213120/donate-body.html File donate-body.html (right): http://codereview.adblockplus.org/6691530349740032/diff/5629499534213120/donate-body.html#newcode72 donate-body.html:72: <div id="subscription-cancellation"> Actually, this element will never match the ...
Jan. 7, 2015, 5:01 p.m. (2015-01-07 17:01:21 UTC) #6
saroyanm
http://codereview.adblockplus.org/6691530349740032/diff/5629499534213120/donate-body.html File donate-body.html (right): http://codereview.adblockplus.org/6691530349740032/diff/5629499534213120/donate-body.html#newcode72 donate-body.html:72: <div id="subscription-cancellation"> On 2015/01/07 17:01:21, Thomas Greiner wrote: > ...
Jan. 7, 2015, 5:05 p.m. (2015-01-07 17:05:32 UTC) #7
Thomas Greiner
Jan. 7, 2015, 5:34 p.m. (2015-01-07 17:34:04 UTC) #8 
LGTM

Powered by Google App Engine
This is Rietveld