Issue 6693736058716160: Catch all exceptions from libadblockplus and rethrow them as Java exceptions

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6693736058716160: Catch all exceptions from libadblockplus and rethrow them as Java exceptions (Closed)

Created:
Nov. 16, 2013, 4:11 p.m. by Felix Dahlke

Modified:
Nov. 22, 2013, 6:10 p.m.

Reviewers:
Andrey Novikov, Wladimir Palant

Visibility:
Public.

Description

With this, we'll catch all exceptions from libadblockplus and rethrow them as Java exceptions. Note that I went against Wladimir's suggestion and added a try block around every engine invocation. Even if we know that certain methods won't throw an exception now, I don't want to segfault if they do later.

Patch Set 1 : #

Patch Set 2 : Rebased on branch libadblockplus #

Created: Nov. 18, 2013, 3:58 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+219 lines, -78 lines)			Patch
	M	jni/abpEngine.cpp	View	1	3 chunks	+219 lines, -78 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Felix Dahlke

Rebased these changes on the libadblockplus branch.

Nov. 18, 2013, 4:14 p.m. (2013-11-18 16:14:56 UTC) #2

Wladimir Palant

Nov. 22, 2013, 6:07 p.m. (2013-11-22 18:07:22 UTC) #3

LGTM assuming that only try..catch blocks have been added and the code inside
didn't change (hard to tell without hg diff -b).

Expand All Messages | Collapse All Messages