Issue 6700499810123776: Issue 520 - Add German and Russian translation to PAD files

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6700499810123776: Issue 520 - Add German and Russian translation to PAD files (Closed)

Created:
June 12, 2014, 1:53 p.m. by Sebastian Noack

Modified:
June 13, 2014, 9:45 a.m.

Reviewers:
Wladimir Palant

Visibility:
Public.

Description

Issue 520 - Add German and Russian translation to PAD files

Patch Set 1 #

Created: June 12, 2014, 1:53 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+123 lines, -8 lines)			Patch
M	sitescripts/extensions/pad/language.py	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	sitescripts/extensions/pad/validation.py	View	4 chunks	+12 lines, -7 lines	0 comments	Download
M	sitescripts/extensions/template/pad.xml	View	2 chunks	+108 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Wladimir Palant

Quite a mess... This makes me really wish that the descriptions are read from the ...

June 13, 2014, 9:19 a.m. (2014-06-13 09:19:58 UTC) #2

Sebastian Noack

June 13, 2014, 9:45 a.m. (2014-06-13 09:45:54 UTC) #3

On 2014/06/13 09:19:58, Wladimir Palant wrote:
> Quite a mess... This makes me really wish that the descriptions are read from
> the corresponding locale files properly. Also, updating validation rules will
be
> a lot harder now.
> 
> Still LGTM I guess.

I agree. But I don't have any better idea.

Putting the descriptions in the locale files in the extension's repo has some
flaws:
1. You would need to parse different locale formats.
2. You wouldn't be able to share descriptions or parts of them across extensions
anymore.
3. And you might not be able anymore to change the description without releasing
a new version.

Putting the descriptions into separate files inside the sitescripts repo might
work. But that approach would also become rather complex if you want to achieve
full flexibility, but also want to be able to reuse descriptions that are the
same for multiple extensions.

Expand All Messages | Collapse All Messages