Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in

Issue 6726956523454464: Issue 153 - Reimplement io.js based on OS.File API (Closed)

Can't Edit
Can't Publish+Mail
Start Review
5 years, 7 months ago by Wladimir Palant
5 years, 7 months ago
Felix Dahlke


The new API is considerably simpler than the old approaches and moves all I/O off the main thread, not just read and write operations. The changes as far as our API is concerned: * Reading from URL is no longer possible (consistent with the Chrome implementation). * The encode/decode parameter is unused, UTF-8 encoding is always being used now (consistent with the Chrome implementation). * defaults/patterns.ini is no longer being used as fallback, instead FilterStorage.firstRun flag is being set (allows removing our current hack in Chrome and implement detection of missing patterns.ini properly).

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -149 lines) Patch
M .hgsubstate View 1 chunk +1 line, -1 line 0 comments Download
M lib/filterStorage.js View 2 chunks +11 lines, -2 lines 0 comments Download
M lib/io.js View 4 chunks +91 lines, -141 lines 1 comment Download
M metadata.gecko View 1 chunk +5 lines, -5 lines 0 comments Download


Total messages: 2
Wladimir Palant
5 years, 7 months ago (2014-03-21 13:10:24 UTC) #1
Felix Dahlke
5 years, 7 months ago (2014-03-21 15:44:26 UTC) #2
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5