Issue 6726956523454464: Issue 153 - Reimplement io.js based on OS.File API

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6726956523454464: Issue 153 - Reimplement io.js based on OS.File API (Closed)

Created:
March 21, 2014, 1:10 p.m. by Wladimir Palant

Modified:
March 21, 2014, 5:39 p.m.

Reviewers:
Felix Dahlke

Visibility:
Public.

Description

The new API is considerably simpler than the old approaches and moves all I/O off the main thread, not just read and write operations. The changes as far as our API is concerned: * Reading from URL is no longer possible (consistent with the Chrome implementation). * The encode/decode parameter is unused, UTF-8 encoding is always being used now (consistent with the Chrome implementation). * defaults/patterns.ini is no longer being used as fallback, instead FilterStorage.firstRun flag is being set (allows removing our current hack in Chrome and implement detection of missing patterns.ini properly).

Patch Set 1 #

Total comments: 1

Created: March 21, 2014, 1:10 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+108 lines, -149 lines)			Patch
M	.hgsubstate	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/filterStorage.js	View	2 chunks	+11 lines, -2 lines	0 comments	Download
M	lib/io.js	View	4 chunks	+91 lines, -141 lines	1 comment	Download
M	metadata.gecko	View	1 chunk	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Felix Dahlke

March 21, 2014, 3:44 p.m. (2014-03-21 15:44:26 UTC) #2

LGTM with the nit addressed, nice!

http://codereview.adblockplus.org/6726956523454464/diff/5629499534213120/lib/...
File lib/io.js (right):

http://codereview.adblockplus.org/6726956523454464/diff/5629499534213120/lib/...
lib/io.js:333: })
Missing semicolon.

Expand All Messages | Collapse All Messages