Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 8329305: Fixed issue reporter`s progress labels for right-to-left languages (Closed)

Created:
Sept. 14, 2012, 9:09 p.m. by Wladimir Palant
Modified:
Sept. 18, 2012, 12:57 p.m.
Reviewers:
Wladimir Palant
CC:
Thomas Greiner
Visibility:
Public.

Description

I already reviewed this but I wanted to add it to the new review system nevertheless.

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M chrome/content/ui/progressBar.js View 1 4 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 3
Wladimir Palant
Sept. 14, 2012, 9:09 p.m. (2012-09-14 21:09:19 UTC) #1
Wladimir Palant
http://codereview.adblockplus.org/8329305/diff/1/chrome/content/ui/progressBar.js File chrome/content/ui/progressBar.js (right): http://codereview.adblockplus.org/8329305/diff/1/chrome/content/ui/progressBar.js#newcode48 chrome/content/ui/progressBar.js:48: if(isRTL) Style nit: please insert a space between "if" ...
Sept. 14, 2012, 9:20 p.m. (2012-09-14 21:20:40 UTC) #2
Wladimir Palant
Sept. 18, 2012, 12:57 p.m. (2012-09-18 12:57:21 UTC) #3
r+ - it all boiled down to a nice simple patch.

Powered by Google App Engine
This is Rietveld