Align whitelisting behavior in Chrome with Firefox

Made sure that document-wide exceptions are considered on all levels (meaning that an exception can apply to a single frame) and not just the top level; added support for element hiding-only exceptions

[Felix Dahlke, 2012-09-18 13:23:14]

I've reviewed your changes. My comments are just nit picking, I have no reason
to believe that there's a real problem here, not being very familiar with the
code base yet.

http://codereview.adblockplus.org/8354161/diff/1/background.js
File background.js (right):

http://codereview.adblockplus.org/8354161/diff/1/background.js#newcode57
background.js:57: function isWhitelisted(url, type)
The new type parameter isn't documented above.

http://codereview.adblockplus.org/8354161/diff/1/background.js#newcode366
background.js:366: var tabId = sender.tab.id;
You're redeclaring tabId here.

http://codereview.adblockplus.org/8354161/diff/1/background.js#newcode367
background.js:367: if (tabId in frames)
I don't think this statement is necessary here. The "f in frames[tabId]" below
should handle frames[tabId] being undefined. Still a bit of a code style
question though, it's more explicit this way.

http://codereview.adblockplus.org/8354161/diff/1/webrequest.js
File webrequest.js (right):

http://codereview.adblockplus.org/8354161/diff/1/webrequest.js#newcode20
webrequest.js:20: recordFrame(details.tabId, details.frameId,
details.parentFrameId, details.url, type == "main_frame");
type == "main_frame" is redundant here, I'd assign the result to a variable once
and use that.

http://codereview.adblockplus.org/8354161/diff/1/webrequest.js#newcode64
webrequest.js:64: function recordFrame(tabId, frameId, parentFrameId, frameUrl,
isMain)
This parameter is no longer used, it could be removed from the signature.

[Wladimir Palant, 2012-09-18 15:12:11]

I fixed everything other than that one style nit.

http://codereview.adblockplus.org/8354161/diff/1/background.js
File background.js (right):

http://codereview.adblockplus.org/8354161/diff/1/background.js#newcode367
background.js:367: if (tabId in frames)
On 2012/09/18 13:23:14, Felix H. Dahlke wrote:
> I don't think this statement is necessary here. The "f in frames[tabId]" below
> should handle frames[tabId] being undefined. Still a bit of a code style
> question though, it's more explicit this way.

Yes, I don't usually rely on this and generally avoid dealing with undefined
values - Firefox warns you about that if you switch on warnings so I just don't.

[Felix Dahlke, 2012-09-18 15:13:41]

On 2012/09/18 15:12:11, Wladimir Palant wrote:
> Yes, I don't usually rely on this and generally avoid dealing with undefined
> values - Firefox warns you about that if you switch on warnings so I just
don't.

Fine by me, LGTM.