Issue 8396008: Fixed: Don't access string bundle using a constant URL to avoid hitting bug 719376

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8396008: Fixed: Don't access string bundle using a constant URL to avoid hitting bug 719376 (Closed)

Created:
Sept. 20, 2012, 11:11 a.m. by Wladimir Palant

Modified:
Sept. 25, 2012, 4:49 p.m.

Reviewers:
Thomas Greiner

Visibility:
Public.

Description

We should not access properties files using a constant URL - the string bundles are cached meaning that an updated Diagnostics version might end up using the string bundle from the previous version if updated without browser restart. Randomizing URLs is ugly when using <stringbundle> tag so I am going to nsIStringBundle directly instead.

Patch Set 1 #

Created: Sept. 20, 2012, 11:11 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -18 lines)			Patch
	M	chrome/content/watcher.js	View		2 chunks	+14 lines, -14 lines	0 comments	Download
	M	chrome/content/watcher.xul	View		1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

OK

Expand All Messages | Collapse All Messages