Issue 8401090: Modified server-side rules generation to produce prioritized domain lists instead of complete suffi…

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8401090: Modified server-side rules generation to produce prioritized domain lists instead of complete suffi… (Closed)

Created:
Sept. 25, 2012, 11:32 a.m. by Wladimir Palant

Modified:
Nov. 21, 2012, 4:33 p.m.

Reviewers:
Thomas Greiner

Visibility:
Public.

Description

Modified server-side rules generation to produce prioritized domain lists instead of complete suffi…

Patch Set 1 #

Total comments: 2

Created: Sept. 25, 2012, 11:32 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -23 lines)			Patch
	M	defaults/rules.json	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	updateRules.py	View		4 chunks	+2 lines, -22 lines	2 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Thomas Greiner

Looks good. http://codereview.adblockplus.org/8401090/diff/1/updateRules.py File updateRules.py (right): http://codereview.adblockplus.org/8401090/diff/1/updateRules.py#newcode311 updateRules.py:311: path = os.path.join('defaults', 'rules.json') Do you really ...

Sept. 25, 2012, 12:31 p.m. (2012-09-25 12:31:36 UTC) #2

Wladimir Palant

Sept. 25, 2012, 1:25 p.m. (2012-09-25 13:25:59 UTC) #3

I reverted this change for now, it seems to be unnecessary after all.

http://codereview.adblockplus.org/8401090/diff/1/updateRules.py
File updateRules.py (right):

http://codereview.adblockplus.org/8401090/diff/1/updateRules.py#newcode311
updateRules.py:311: path = os.path.join('defaults', 'rules.json')
On 2012/09/25 12:31:37, Thomas Greiner wrote:
> Do you really want the file to be located at /defaults/rules.json?

Actually, it's defaults/rules.json (relative to the current work directory).
This is a bit ugly because it makes the assumption that the script will always
be run from the extension root but other than that it should be fine.

Expand All Messages | Collapse All Messages