Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 8410038: Removed backwards compatibility code (Closed)

Created:
Sept. 22, 2012, 2:35 p.m. by Wladimir Palant
Modified:
Sept. 28, 2012, 8:05 a.m.
Reviewers:
Thomas Greiner
Visibility:
Public.

Description

ABP 2.0.x used a different module loading mechanism, not much point to continue supporting it; also not much point keeping a work-around for a bug fixed in Firefox 14

Patch Set 1 #

Patch Set 2 : Forgot the metadata change #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -18 lines) Patch
M chrome/content/watcher.js View 1 chunk +2 lines, -15 lines 2 comments Download
M metadata View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5
Wladimir Palant
Sept. 22, 2012, 2:35 p.m. (2012-09-22 14:35:58 UTC) #1
Wladimir Palant
Forgot the metadata change
Sept. 22, 2012, 2:37 p.m. (2012-09-22 14:37:31 UTC) #2
Thomas Greiner
OK http://codereview.adblockplus.org/8410038/diff/3001/chrome/content/watcher.js File chrome/content/watcher.js (right): http://codereview.adblockplus.org/8410038/diff/3001/chrome/content/watcher.js#newcode34 chrome/content/watcher.js:34: window.close(); Could also be written as: let PolicyPrivate ...
Sept. 26, 2012, 1:55 p.m. (2012-09-26 13:55:04 UTC) #3
Wladimir Palant
http://codereview.adblockplus.org/8410038/diff/3001/chrome/content/watcher.js File chrome/content/watcher.js (right): http://codereview.adblockplus.org/8410038/diff/3001/chrome/content/watcher.js#newcode34 chrome/content/watcher.js:34: window.close(); On 2012/09/26 13:55:04, Thomas Greiner wrote: > Could ...
Sept. 27, 2012, 2:39 p.m. (2012-09-27 14:39:29 UTC) #4
Thomas Greiner
Sept. 28, 2012, 8:05 a.m. (2012-09-28 08:05:24 UTC) #5
OK
personal preferences differ but that's not an issue

Powered by Google App Engine
This is Rietveld