Issue 8482159: Initial element hiding functionality

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8482159: Initial element hiding functionality (Closed)

Created:
Oct. 9, 2012, 10:42 a.m. by Wladimir Palant

Modified:
Nov. 14, 2012, 6:32 a.m.

Reviewers:
Felix Dahlke

Visibility:
Public.

Patch Set 1 #

Total comments: 4

Created: Oct. 9, 2012, 10:42 a.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+329 lines, -32 lines)			Patch
M	background.js	View	2 chunks	+14 lines, -0 lines	2 comments	Download
R	includes/cssFilter.js	View	1 chunk	+0 lines, -32 lines	0 comments	Download
A	includes/include.preload.js	View	1 chunk	+72 lines, -0 lines	2 comments	Download
M	index.html	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	lib/basedomain.js	View	1 chunk	+242 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Felix Dahlke

Review done. I've ignored lib/basedomain.js since that's identical to what we have in Chrome. http://codereview.adblockplus.org/8482159/diff/1/background.js ...

Oct. 10, 2012, 2:21 p.m. (2012-10-10 14:21:42 UTC) #2

Wladimir Palant

http://codereview.adblockplus.org/8482159/diff/1/background.js File background.js (right): http://codereview.adblockplus.org/8482159/diff/1/background.js#newcode152 background.js:152: switch (request.reqtype) On 2012/10/10 14:21:42, Felix H. Dahlke wrote: ...

Oct. 17, 2012, 10:15 a.m. (2012-10-17 10:15:56 UTC) #3

Felix Dahlke

Oct. 17, 2012, 10:16 a.m. (2012-10-17 10:16:52 UTC) #4

On 2012/10/17 10:15:56, Wladimir Palant wrote:
> http://codereview.adblockplus.org/8482159/diff/1/background.js
> File background.js (right):
> 
> http://codereview.adblockplus.org/8482159/diff/1/background.js#newcode152
> background.js:152: switch (request.reqtype)
> On 2012/10/10 14:21:42, Felix H. Dahlke wrote:
> > I'd prefer an if here, since there is only one case.
> 
> This code is essentially identical to Chrome and we will most definitely add
> more cases here once we have more UI.

OK, LGTM

Expand All Messages | Collapse All Messages