Issue 8483004: abpbot: Send each commit's branch to IRC

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8483004: abpbot: Send each commit's branch to IRC (Closed)

Created:
Sept. 29, 2012, 6:06 a.m. by Felix Dahlke

Modified:
Oct. 2, 2012, 12:40 p.m.

Reviewers:
Wladimir Palant

Visibility:
Public.

Description

I wanted to see the branch of each commit in IRC. Please test these changes, as I was only able to test them in isolation. (Once we introduce Puppet, we can test stuff like this in a realistic environment.)

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Created: Oct. 2, 2012, 10:57 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	beanbot-client.py	View	1 2	1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Wladimir Palant

LGTM if you insist on doing it your way. http://codereview.adblockplus.org/8483004/diff/1/beanbot-client.py File beanbot-client.py (right): http://codereview.adblockplus.org/8483004/diff/1/beanbot-client.py#newcode24 beanbot-client.py:24: ...

Oct. 1, 2012, 11:23 a.m. (2012-10-01 11:23:42 UTC) #2

Felix Dahlke

Oct. 2, 2012, 5:39 a.m. (2012-10-02 05:39:26 UTC) #3

http://codereview.adblockplus.org/8483004/diff/1/beanbot-client.py
File beanbot-client.py (right):

http://codereview.adblockplus.org/8483004/diff/1/beanbot-client.py#newcode24
beanbot-client.py:24: "%(IRC_LIME)s%(branch)s "
On 2012/10/01 11:23:42, Wladimir Palant wrote:
> Better not to use too many colors. How about [%(branch)s] (normal text)?

Done.

Expand All Messages | Collapse All Messages