Slightly improved notification for fennec

lib/appIntegration.js

 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this file,
  * You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 let {hook} = require("hooks");
 let functionHooks = new WeakMap();
 
 exports.removeFromWindow = function(window)
 {
   if (functionHooks.has(window))
@@ skipping 253 matching lines @@
           }
         }, cleanup);
         functionHooks.set(window, unhook);
       }
     };
 
     exports.openInfobar = function(window, id, message, buttons, persistence)
     {
       if ("BrowserApp" in window && "selectedTab" in window.BrowserApp)
       {
-        window.NativeWindow.doorhanger.show(message, id, buttons, window.BrowserApp.selectedTab.id,
+        let tabId = window.BrowserApp.selectedTab.id;
+        window.NativeWindow.doorhanger.show(message, id, buttons, tabId,
           {
-            persistence: persistence
+            // No navigation is happening after doorhanger is shown
+            // so persistence needs to be reduced by one
+            persistence: persistence-1,
+            timeout: 5000

[Wladimir Palant, 2012/10/02 13:03:45]

As discussed on IRC - looks like doorhanger notifications aren't really meant to
be transient, let's just remove the timeout then (the timeout option doesn't
really do what I thought it would).

LGTM if you also add spaces before and after the minus (-) on the line before.

           }
         );
       }
     };
 
     exports.loadURI = function(window, uri)
     {
       if ("BrowserApp" in window && "loadURI" in window.BrowserApp)
         window.BrowserApp.loadURI(uri);
     };
 
     break;
   }
   default:
   {
     exports.isKnownWindow = function(window) false;
     break;
   }
 }