Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 8487012: Slightly improved notification for fennec (Closed)

Created:
Oct. 1, 2012, 4:15 p.m. by Thomas Greiner
Modified:
Nov. 21, 2012, 4:36 p.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Slightly improved notification for fennec

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M lib/appIntegration.js View 1 1 chunk +6 lines, -2 lines 1 comment Download

Messages

Total messages: 5
Thomas Greiner
Oct. 1, 2012, 4:15 p.m. (2012-10-01 16:15:05 UTC) #1
Thomas Greiner
Oct. 1, 2012, 4:17 p.m. (2012-10-01 16:17:14 UTC) #2
Wladimir Palant
http://codereview.adblockplus.org/8487012/diff/1/lib/appIntegration.js File lib/appIntegration.js (right): http://codereview.adblockplus.org/8487012/diff/1/lib/appIntegration.js#newcode286 lib/appIntegration.js:286: }, 5000, Ci.nsITimer.TYPE_ONE_SHOT); https://developer.mozilla.org/en-US/docs/Extensions/Mobile/API/NativeWindow/doorhanger/show#Syntax - bitte nach "timeout" suchen.
Oct. 1, 2012, 8:36 p.m. (2012-10-01 20:36:33 UTC) #3
Thomas Greiner
Oct. 2, 2012, 11:01 a.m. (2012-10-02 11:01:24 UTC) #4
Wladimir Palant
Oct. 2, 2012, 1:03 p.m. (2012-10-02 13:03:45 UTC) #5
http://codereview.adblockplus.org/8487012/diff/3/lib/appIntegration.js
File lib/appIntegration.js (right):

http://codereview.adblockplus.org/8487012/diff/3/lib/appIntegration.js#newcod...
lib/appIntegration.js:280: timeout: 5000
As discussed on IRC - looks like doorhanger notifications aren't really meant to
be transient, let's just remove the timeout then (the timeout option doesn't
really do what I thought it would).

LGTM if you also add spaces before and after the minus (-) on the line before.

Powered by Google App Engine
This is Rietveld