Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 8492145: Fixed: IO.readFromFile expects a listener object, not a callback (Closed)

Created:
Oct. 9, 2012, 5:56 a.m. by Wladimir Palant
Modified:
Oct. 9, 2012, 6:20 a.m.
Reviewers:
Felix Dahlke
Visibility:
Public.

Description

Fixed: IO.readFromFile expects a listener object, not a callback

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M .hgsubstate View 1 chunk +1 line, -1 line 1 comment Download
M lib/adblockplus_compat.js View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 3
Wladimir Palant
Oct. 9, 2012, 5:56 a.m. (2012-10-09 05:56:16 UTC) #1
Felix Dahlke
LGTM, although I don't know whether that .hgsubstate change is related or necessary. http://codereview.adblockplus.org/8492145/diff/1/.hgsubstate File ...
Oct. 9, 2012, 6:11 a.m. (2012-10-09 06:11:49 UTC) #2
Wladimir Palant
Oct. 9, 2012, 6:19 a.m. (2012-10-09 06:19:50 UTC) #3
On 2012/10/09 06:11:49, Felix H. Dahlke wrote:
> http://codereview.adblockplus.org/8492145/diff/1/.hgsubstate#oldcode1
> .hgsubstate:1: bf1eecf1f08fee35381ea2ea2eb5c20ba9396d2d buildtools
> This change does not seem related.

No, it's not - there have been unrelated commits in the buildtools repository so
its state is updated. I cannot commit without this change.

Powered by Google App Engine
This is Rietveld