Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 8556073: Fixed: writing patterns.ini might leave left-overs from previous content (Closed)

Created:
Oct. 12, 2012, 7:46 a.m. by Wladimir Palant
Modified:
Oct. 12, 2012, 2:26 p.m.
Reviewers:
Felix Dahlke
Visibility:
Public.

Description

This fixes the file truncation bug, also this.lineBreak is being used for consistency

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -22 lines) Patch
M lib/adblockplus_compat.js View 1 1 chunk +30 lines, -22 lines 2 comments Download

Messages

Total messages: 4
Wladimir Palant
Oct. 12, 2012, 7:46 a.m. (2012-10-12 07:46:46 UTC) #1
Felix Dahlke
You could entangle the logic from the nested callbacks, e.g. by putting the actual writing ...
Oct. 12, 2012, 7:59 a.m. (2012-10-12 07:59:38 UTC) #2
Felix Dahlke
http://codereview.adblockplus.org/8556073/diff/4001/lib/adblockplus_compat.js File lib/adblockplus_compat.js (right): http://codereview.adblockplus.org/8556073/diff/4001/lib/adblockplus_compat.js#newcode187 lib/adblockplus_compat.js:187: }.bind(this); Why bind this? Doesn't seem to be used. ...
Oct. 12, 2012, 8:16 a.m. (2012-10-12 08:16:21 UTC) #3
Felix Dahlke
Oct. 12, 2012, 8:18 a.m. (2012-10-12 08:18:02 UTC) #4
LGTM anyway :)

Powered by Google App Engine
This is Rietveld