Issue 8652024: Use new Option() instead of document.createElement("option")

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8652024: Use new Option() instead of document.createElement("option") (Closed)

Created:
Oct. 22, 2012, 11:49 a.m. by Wladimir Palant

Modified:
Oct. 22, 2012, 1:03 p.m.

Reviewers:
Felix Dahlke

Visibility:
Public.

Description

Use new Option() instead of document.createElement("option")

Patch Set 1 #

Created: Oct. 22, 2012, 11:49 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -8 lines)			Patch
	M	.hgsubstate	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	options.js	View		3 chunks	+4 lines, -7 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Felix Dahlke

Oct. 22, 2012, 11:52 a.m. (2012-10-22 11:52:37 UTC) #2

LGTM. We might want to add a comment describing why new Option() has to be used,
but if the code is only used for Opera, that should be self explanatory.

Expand All Messages | Collapse All Messages