Issue 8684113: Improved patterns.ini reading to be more memory-efficient

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8684113: Improved patterns.ini reading to be more memory-efficient (Closed)

Created:
Oct. 30, 2012, 2:51 p.m. by Wladimir Palant

Modified:
Nov. 1, 2012, 7:54 a.m.

Reviewers:
Felix Dahlke

Visibility:
Public.

Description

It seems that string concatenation makes Gecko allocate more memory than necessary to hold the string. Using XMLHttpRequest with moz-chunked-text response type (introduced in Gecko 9) looks like a good way to get implicit string conversion - meaning no more string concatenations. No measurable effect on startup times unfortunately.

Patch Set 1 #

Total comments: 1

Created: Oct. 30, 2012, 2:51 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+61 lines, -65 lines)			Patch
	M	lib/io.js	View		1 chunk	+57 lines, -61 lines	1 comment	Download
	M	metadata	View		1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Felix Dahlke

LGTM other than that nit. And assuming the metadata changes are unrelated. http://codereview.adblockplus.org/8684113/diff/1/lib/io.js File lib/io.js ...

Oct. 30, 2012, 5:40 p.m. (2012-10-30 17:40:06 UTC) #2

Wladimir Palant

The metadata changes are very much related - moz-chunked-text requires Gecko 9 whereas we were ...

Oct. 30, 2012, 6:50 p.m. (2012-10-30 18:50:28 UTC) #3

Felix Dahlke

Oct. 30, 2012, 7:39 p.m. (2012-10-30 19:39:34 UTC) #4

On 2012/10/30 18:50:28, Wladimir Palant wrote:
> The metadata changes are very much related - moz-chunked-text requires Gecko 9
> whereas we were compatible with Gecko 8 before.

Oh. LGTM anyway :)

Expand All Messages | Collapse All Messages