Issue 8688116: Fixed Firefox Sync support (currently broken by refactoring in bug 785225

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8688116: Fixed Firefox Sync support (currently broken by refactoring in bug 785225 (Closed)

Created:
Oct. 30, 2012, 2:47 p.m. by Wladimir Palant

Modified:
Nov. 1, 2012, 7:54 a.m.

Reviewers:
Felix Dahlke

Visibility:
Public.

Description

The main.js module no longer exports any of the symbols we need. Also, the old Engines singleton has been replaced by Service.engineManager and various objects now require references to the service/engine in their constructor.

Patch Set 1 #

Total comments: 3

Created: Oct. 30, 2012, 2:47 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -18 lines)			Patch
	M	lib/sync.js	View		5 chunks	+20 lines, -18 lines	3 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Felix Dahlke

http://codereview.adblockplus.org/8688116/diff/1/lib/sync.js File lib/sync.js (right): http://codereview.adblockplus.org/8688116/diff/1/lib/sync.js#newcode94 lib/sync.js:94: ({Engines, SyncEngine, Store, Tracker} = Cu.import("resource://services-sync/engines.js")); Why surround this ...

Oct. 30, 2012, 5:44 p.m. (2012-10-30 17:44:12 UTC) #2

Wladimir Palant

Oct. 30, 2012, 6:53 p.m. (2012-10-30 18:53:49 UTC) #3

Felix Dahlke

Oct. 30, 2012, 7:40 p.m. (2012-10-30 19:40:04 UTC) #4

On 2012/10/30 18:53:49, Wladimir Palant wrote:
> http://codereview.adblockplus.org/8688116/diff/1/lib/sync.js
> File lib/sync.js (right):
> 
> http://codereview.adblockplus.org/8688116/diff/1/lib/sync.js#newcode94
> lib/sync.js:94: ({Engines, SyncEngine, Store, Tracker} =
> Cu.import("resource://services-sync/engines.js"));
> On 2012/10/30 17:44:12, Felix H. Dahlke wrote:
> > Why surround this with parentheses?
> 
> Because otherwise {...} is a block statement and you get a syntax error -
> similar to function(){...}().

OK, had me wondering. LGTM.

Expand All Messages | Collapse All Messages