share-page: Initial implementation

This is the share page as demonstrated on Monday.

It is possibly not the final design yet, but I think we should review the initial version anyway, so that we can set up a central Mercurial repository and automatic deployment.

[Wladimir Palant, 2012-10-25 07:24:33]

http://codereview.adblockplus.org/8689009/diff/1/css/main.css
File css/main.css (right):

http://codereview.adblockplus.org/8689009/diff/1/css/main.css#newcode14
css/main.css:14: line-height: 120px;
I guess that a lengthy text requiring a line break will mess up everything?

Let's discuss ways to avoid hardcoding sizes in the chat.

http://codereview.adblockplus.org/8689009/diff/1/index.html
File index.html (right):

http://codereview.adblockplus.org/8689009/diff/1/index.html#newcode33
index.html:33: <script src="js/main.js"></script>
I consider listening to DOMContentLoaded cleaner - we are only dealing with
modern browsers.

http://codereview.adblockplus.org/8689009/diff/1/js/main.js
File js/main.js (right):

http://codereview.adblockplus.org/8689009/diff/1/js/main.js#newcode24
js/main.js:24: }
I guess that the ugly initialization code is provided by the respective
platforms?

[Felix Dahlke, 2012-10-25 07:43:45]

On 2012/10/25 07:24:33, Wladimir Palant wrote:
> http://codereview.adblockplus.org/8689009/diff/1/css/main.css
> File css/main.css (right):
> 
> http://codereview.adblockplus.org/8689009/diff/1/css/main.css#newcode14
> css/main.css:14: line-height: 120px;
> I guess that a lengthy text requiring a line break will mess up everything?
> 
> Let's discuss ways to avoid hardcoding sizes in the chat.

I would have used flexbox, but again, I was opting for a solution that works in
older browsers. Since the text isn't variable here, I thought this would do.
Better than centering via JavaScript, which is the only IE6 compatible
alternative I can think of.

> http://codereview.adblockplus.org/8689009/diff/1/index.html
> File index.html (right):
> 
> http://codereview.adblockplus.org/8689009/diff/1/index.html#newcode33
> index.html:33: <script src="js/main.js"></script>
> I consider listening to DOMContentLoaded cleaner - we are only dealing with
> modern browsers.

I can do that, another quirk for old browsers...

> http://codereview.adblockplus.org/8689009/diff/1/js/main.js
> File js/main.js (right):
> 
> http://codereview.adblockplus.org/8689009/diff/1/js/main.js#newcode24
> js/main.js:24: }
> I guess that the ugly initialization code is provided by the respective
> platforms?

Yes. We could definitely remove some parts and make them look nicer, but I
thought it would be a good idea to leave the code copy-pasteable.

[Felix Dahlke, 2012-10-25 13:20:04]

Addressed all issues and uploaded a new patch set. This one also contains code
to send the window size to the parent.

[Wladimir Palant, 2012-10-25 13:28:39]

LGTM