Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 8699074: Fixed: Requests by javascript: or data: frames aren`t being blocked (Closed)

Created:
Oct. 29, 2012, 12:44 p.m. by Wladimir Palant
Modified:
Oct. 30, 2012, 11:12 a.m.
Reviewers:
Thomas Greiner
Visibility:
Public.

Description

Chrome doesn`t send javascript: and data: frames to us so we won`t know these frames but should still block elements in them. Falling back to the top frame in that case (better than nothing).

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -11 lines) Patch
M webrequest.js View 2 chunks +16 lines, -11 lines 0 comments Download

Messages

Total messages: 2
Wladimir Palant
Oct. 29, 2012, 12:44 p.m. (2012-10-29 12:44:14 UTC) #1
Thomas Greiner
Oct. 30, 2012, 10:09 a.m. (2012-10-30 10:09:58 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld