Issue 8741005: Topic 11337 - More reliable approach to hide image/frame placeholders

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8741005: Topic 11337 - More reliable approach to hide image/frame placeholders (Closed)

Created:
Oct. 31, 2012, 9:14 a.m. by Wladimir Palant

Modified:
Nov. 1, 2012, 7:54 a.m.

Reviewers:
Thomas Greiner

Visibility:
Public.

Description

I meant to use the error event from the start but got confused because that event doesn`t bubble - I forgot that a capturing event listener can get it at the top level nevertheless. This works really nicely for images, for frames we have to look at the load event however and check even frames that loaded properly (no way to distinguish them from a content script).

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: Oct. 31, 2012, 12:20 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	.hgsubstate	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	background.js	View	1	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Thomas Greiner

LGTM only one variable name that is confusing http://codereview.adblockplus.org/8741005/diff/1/background.js File background.js (right): http://codereview.adblockplus.org/8741005/diff/1/background.js#newcode541 background.js:541: if ...

Oct. 31, 2012, 11:32 a.m. (2012-10-31 11:32:00 UTC) #2

Wladimir Palant

http://codereview.adblockplus.org/8741005/diff/1/background.js File background.js (right): http://codereview.adblockplus.org/8741005/diff/1/background.js#newcode541 background.js:541: if (!enabled) That's code copied from element hiding handling ...

Oct. 31, 2012, 12:17 p.m. (2012-10-31 12:17:53 UTC) #3

Expand All Messages | Collapse All Messages