background.js - Issue 8741005: Topic 11337 - More reliable approach to hide image/frame placeholders

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: background.js

Issue 8741005: Topic 11337 - More reliable approach to hide image/frame placeholders (Closed)

Patch Set: Created Oct. 31, 2012, 12:20 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: background.js

===================================================================

--- a/background.js

+++ b/background.js

@@ -532,18 +532,17 @@ chrome.extension.onRequest.addListener(f

var tabId = -1;

var frameId = -1;

if (sender.tab)

{

tabId = sender.tab.id;

frameId = getFrameId(tabId, request.documentUrl);

}

- var enabled = !isFrameWhitelisted(tabId, frameId, "DOCUMENT");

- if (!enabled)

+ if (isFrameWhitelisted(tabId, frameId, "DOCUMENT"))

{

sendResponse(false);

break;

}

var requestHost = extractHostFromURL(request.url);

var documentHost = extractHostFromURL(request.documentUrl);

var thirdParty = isThirdParty(requestHost, documentHost);

« no previous file with comments | « .hgsubstate ('k') | no next file » | no next file with comments »