Fixed small memory leak

webrequest.js

 /*
  * This file is part of the Adblock Plus extension,
  * Copyright (C) 2006-2012 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 chrome.webRequest.onBeforeRequest.addListener(onBeforeRequest, {urls: ["http://*/*", "https://*/*"]}, ["blocking"]);
 chrome.webRequest.onHeadersReceived.addListener(onHeadersReceived, {urls: ["http://*/*", "https://*/*"]}, ["responseHeaders"]);
-chrome.tabs.onUpdated.addListener(forgetTab);

[Wladimir Palant, 2012/11/08 13:28:06]

I don't think that this will work like that. This listener will also be called
if the tab finished loading for example. At the very least you need to check
that changeInfo.url is set (tab URL changed). Still, this will probably also
fire on anchor changes when the tab isn't actually reloaded. Finally, we might
still need that data if the user goes back - the previous page might get
displayed without being reloaded (something to be tested).

+chrome.tabs.onUpdated.addListener(onUpdated);
 chrome.tabs.onRemoved.addListener(forgetTab);
 
 var onFilterChangeTimeout = null;
 function onFilterChange()
 {
   onFilterChangeTimeout = null;
   chrome.webRequest.handlerBehaviorChanged();
 }
 
 var importantNotifications = {
@@ skipping 12 matching lines @@
   if (action in importantNotifications)
   {
     // Execute delayed to prevent multiple executions in a quick succession
     if (onFilterChangeTimeout != null)
       window.clearTimeout(onFilterChangeTimeout);
     onFilterChangeTimeout = window.setTimeout(onFilterChange, 2000);
   }
 });
 
 var frames = {};
+
+function onUpdated(tabId, changeInfo, tab)
+{
+  var url = changeInfo.url;
+  if (url)
+  {
+    if (url.indexOf("#") > -1)
+      url = url.match(/^(.*?)#/) && RegExp.$1;
+    var lastURL = tabId in frames && frames[tabId].lastURL;
+    if (lastURL != url)

[Wladimir Palant, 2012/11/08 16:58:27]

And now try window.history.pushState() to change URL without reloading...

+    {
+      if (lastURL)
+        forgetTab(tabId);
+      
+      if (!(tabId in frames))
+        frames[tabId] = {};
+      
+      frames[tabId].lastURL = url;
+    }
+  }
+}
 
 function onBeforeRequest(details)
 {
   if (details.tabId == -1)
     return {};
 
   var type = details.type;
   if (type == "main_frame" || type == "sub_frame")
     recordFrame(details.tabId, details.frameId, details.parentFrameId, details.url);
 
@@ skipping 128 matching lines @@
     parent = frameData.parent;
     parentData = getFrameData(tabId, parent);
 
     var frameUrl = frameData.url;
     var parentUrl = (parentData ? parentData.url : frameUrl);
     if ("keyException" in frameData || isWhitelisted(frameUrl, parentUrl, type))
       return true;
   }
   return false;
 }