Fixed small memory leak

Content of frames array is only released when tab is closed and not on refresh or on navigation to a different website. This is a problem for tabs that remain open for a long time.

[Wladimir Palant, 2012-11-08 13:28:05]

http://codereview.adblockplus.org/8756093/diff/1/webrequest.js
File webrequest.js (right):

http://codereview.adblockplus.org/8756093/diff/1/webrequest.js#newcode20
webrequest.js:20: chrome.tabs.onUpdated.addListener(forgetTab);
I don't think that this will work like that. This listener will also be called
if the tab finished loading for example. At the very least you need to check
that changeInfo.url is set (tab URL changed). Still, this will probably also
fire on anchor changes when the tab isn't actually reloaded. Finally, we might
still need that data if the user goes back - the previous page might get
displayed without being reloaded (something to be tested).

[Thomas Greiner, 2012-11-08 16:18:43]

On 2012/11/08 13:28:05, Wladimir Palant wrote:
> http://codereview.adblockplus.org/8756093/diff/1/webrequest.js
> File webrequest.js (right):
> 
> http://codereview.adblockplus.org/8756093/diff/1/webrequest.js#newcode20
> webrequest.js:20: chrome.tabs.onUpdated.addListener(forgetTab);
> I don't think that this will work like that. This listener will also be called
> if the tab finished loading for example. At the very least you need to check
> that changeInfo.url is set (tab URL changed). Still, this will probably also
> fire on anchor changes when the tab isn't actually reloaded. Finally, we might
> still need that data if the user goes back - the previous page might get
> displayed without being reloaded (something to be tested).

It fires when...
- user navigates to new URL
- redirect happens
- hash changes
- back- or forward button is pressed
...so basically in all cases

[Wladimir Palant, 2012-11-08 16:58:27]

http://codereview.adblockplus.org/8756093/diff/4001/webrequest.js
File webrequest.js (right):

http://codereview.adblockplus.org/8756093/diff/4001/webrequest.js#newcode62
webrequest.js:62: if (lastURL != url)
And now try window.history.pushState() to change URL without reloading...