Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 8787016: Remove "disable inline text-ads" feature (Closed)

Created:
Nov. 6, 2012, 7:19 a.m. by Felix Dahlke
Modified:
Nov. 6, 2012, 8:45 a.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -120 lines) Patch
M background.js View 1 3 chunks +12 lines, -7 lines 0 comments Download
R include.textads.js View 1 chunk +0 lines, -108 lines 0 comments Download
M manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M options.html View 1 chunk +0 lines, -3 lines 0 comments Download
M options.js View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5
Felix Dahlke
Nov. 6, 2012, 7:19 a.m. (2012-11-06 07:19:42 UTC) #1
Wladimir Palant
LGTM with the two comments addressed. http://codereview.adblockplus.org/8787016/diff/1/background.js File background.js (right): http://codereview.adblockplus.org/8787016/diff/1/background.js#newcode80 background.js:80: delete localStorage.experimental; Please ...
Nov. 6, 2012, 8:06 a.m. (2012-11-06 08:06:11 UTC) #2
Felix Dahlke
I've uploaded a new patch set since one of my changes was non-trivial. http://codereview.adblockplus.org/8787016/diff/1/background.js File ...
Nov. 6, 2012, 8:16 a.m. (2012-11-06 08:16:37 UTC) #3
Felix Dahlke
I've uploaded a new patch set since one of my changes was non-trivial.
Nov. 6, 2012, 8:16 a.m. (2012-11-06 08:16:59 UTC) #4
Wladimir Palant
Nov. 6, 2012, 8:36 a.m. (2012-11-06 08:36:00 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld