Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 8892049: adblockplusopera: Fix error occuring when updating from AdBlock for Chrome (Closed)

Created:
Nov. 21, 2012, 9:52 a.m. by Felix Dahlke
Modified:
Nov. 21, 2012, 10:24 a.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M background.js View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 2
Wladimir Palant
This change looks like it shouldn't have any effect at all. Even if it is ...
Nov. 21, 2012, 10:08 a.m. (2012-11-21 10:08:21 UTC) #1
Felix Dahlke
Nov. 21, 2012, 10:24 a.m. (2012-11-21 10:24:14 UTC) #2
On 2012/11/21 10:08:21, Wladimir Palant wrote:
> This change looks like it shouldn't have any effect at all. Even if it is a
> valid work-around - we need to figure out what's happening here exactly and
add
> a comment explaining it. Otherwise somebody will come later and "optimize"
that
> fix away.

Turns out this didn't even fix the issue, it's just not reliably reproducible.
I'll close this issue and try to come up with something better.

Powered by Google App Engine
This is Rietveld