Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 8893047: adblockplusopera: Fix loading race condition (Closed)

Created:
Nov. 21, 2012, 2:47 p.m. by Felix Dahlke
Modified:
Dec. 3, 2012, 5:29 a.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

When starting Opera, a race condition will sometimes occur. It can most easily be reproduced by installing several other extensions (as much as 18 for me), but I suspect it's happening even with only ABP installed on less powerful machines.

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -7 lines) Patch
M lib/adblockplus_compat.js View 1 4 chunks +13 lines, -7 lines 0 comments Download

Messages

Total messages: 3
Wladimir Palant
There are more setTimeout() calls in that file, I think you should replace all of ...
Nov. 21, 2012, 3:47 p.m. (2012-11-21 15:47:57 UTC) #1
Felix Dahlke
Issues addressed. There's still one setTimeout call left, but that has a delay, so it's ...
Nov. 21, 2012, 3:56 p.m. (2012-11-21 15:56:55 UTC) #2
Wladimir Palant
Nov. 21, 2012, 4:06 p.m. (2012-11-21 16:06:41 UTC) #3
LGTM

Please note however that additional parameters in runAsync are deprecated - that
functionality pre-dates Function.bind() and should be replaced by it eventually.

Powered by Google App Engine
This is Rietveld