Ported changes from Adblock Plus integration back into URL Fixer

Ported changes from Adblock Plus integration back into URL Fixer

[Wladimir Palant, 2012-12-13 16:07:00]

Sorry it took so long.

http://codereview.adblockplus.org/8948027/diff/1/lib/typoCollector.js
File lib/typoCollector.js (right):

http://codereview.adblockplus.org/8948027/diff/1/lib/typoCollector.js#newcode1
lib/typoCollector.js:1: /*
This one has been properly renamed to keep history (hg rename), right? This
shows up as a new file here, probably rietveld to blame for that...

http://codereview.adblockplus.org/8948027/diff/1/lib/typoNetError.js
File lib/typoNetError.js (right):

http://codereview.adblockplus.org/8948027/diff/1/lib/typoNetError.js#newcode33
lib/typoNetError.js:33: exports.applyToWindow = applyToWindow;
How about netError uses its own WindowObserver so it doesn't depend on typoFixer
to call it? This observer can be initialized along with netErrorOverlay to make
sure nothing happens before it is loaded.

http://codereview.adblockplus.org/8948027/diff/1/lib/typoSurvey.js
File lib/typoSurvey.js (right):

http://codereview.adblockplus.org/8948027/diff/1/lib/typoSurvey.js#newcode1
lib/typoSurvey.js:1: /*
Same question as for typoCollector.js - this has been properly renamed, right?

[Thomas Greiner, 2013-01-14 10:06:41]

http://codereview.adblockplus.org/8948027/diff/1/lib/typoCollector.js
File lib/typoCollector.js (right):

http://codereview.adblockplus.org/8948027/diff/1/lib/typoCollector.js#newcode1
lib/typoCollector.js:1: /*
On 2012/12/13 16:07:00, Wladimir Palant wrote:
> This one has been properly renamed to keep history (hg rename), right? This
> shows up as a new file here, probably rietveld to blame for that...

Yes, it was IIRC.

http://codereview.adblockplus.org/8948027/diff/1/lib/typoNetError.js
File lib/typoNetError.js (right):

http://codereview.adblockplus.org/8948027/diff/1/lib/typoNetError.js#newcode33
lib/typoNetError.js:33: exports.applyToWindow = applyToWindow;
On 2012/12/13 16:07:00, Wladimir Palant wrote:
> How about netError uses its own WindowObserver so it doesn't depend on
typoFixer
> to call it? This observer can be initialized along with netErrorOverlay to
make
> sure nothing happens before it is loaded.

Done.

http://codereview.adblockplus.org/8948027/diff/1/lib/typoSurvey.js
File lib/typoSurvey.js (right):

http://codereview.adblockplus.org/8948027/diff/1/lib/typoSurvey.js#newcode1
lib/typoSurvey.js:1: /*
On 2012/12/13 16:07:00, Wladimir Palant wrote:
> Same question as for typoCollector.js - this has been properly renamed, right?

Same answer: IIRC yes.

[Wladimir Palant, 2013-01-14 10:37:58]

LGTM