android: brazil StringIndexOutOfBoundsException fix

android: brazil StringIndexOutOfBoundsException fix

[Wladimir Palant, 2012-11-27 11:59:17]

http://codereview.adblockplus.org/8961044/diff/1/src/sunlabs/brazil/util/http...
File src/sunlabs/brazil/util/http/HttpUtil.java (right):

http://codereview.adblockplus.org/8961044/diff/1/src/sunlabs/brazil/util/http...
src/sunlabs/brazil/util/http/HttpUtil.java:105: *
Is this change necessary?

http://codereview.adblockplus.org/8961044/diff/1/src/sunlabs/brazil/util/http...
src/sunlabs/brazil/util/http/HttpUtil.java:300: date = date.substring(0, 29);
I suspect that removing that check completely is better. My impression is that
realistically we can only get an issue here if the properties file for the US
locale is bad (missing week days or such). This means that we already
misformatted the date, by truncating it to 29 characters blindly we risk making
things worse.

http://codereview.adblockplus.org/8961044/diff/1/src/sunlabs/brazil/util/http...
src/sunlabs/brazil/util/http/HttpUtil.java:301: return date;
Indentation seems to be messed up here - you should either use tabs as the
original code (preferred) or replace all the tabs by spaces in a separate commit
first.

[Wladimir Palant, 2012-11-27 12:55:10]

http://codereview.adblockplus.org/8961044/diff/1/src/sunlabs/brazil/util/http...
File src/sunlabs/brazil/util/http/HttpUtil.java (right):

http://codereview.adblockplus.org/8961044/diff/1/src/sunlabs/brazil/util/http...
src/sunlabs/brazil/util/http/HttpUtil.java:300: date = date.substring(0, 29);
Ok, so the point here is removing +00:00 at the end. Ideally we would adjust the
format (remove "z" at the end and just add "GMT" ourselves) but parseTime()
below makes that hard. So maybe just look for the last occurrence of "+" in the
result and truncate to that point if you find it.

[Andrey Novikov, 2012-11-27 13:03:19]

http://codereview.adblockplus.org/8961044/diff/1/src/sunlabs/brazil/util/http...
File src/sunlabs/brazil/util/http/HttpUtil.java (right):

http://codereview.adblockplus.org/8961044/diff/1/src/sunlabs/brazil/util/http...
src/sunlabs/brazil/util/http/HttpUtil.java:105: *
On 2012/11/27 11:59:17, Wladimir Palant wrote:
> Is this change necessary?

Done.

http://codereview.adblockplus.org/8961044/diff/1/src/sunlabs/brazil/util/http...
src/sunlabs/brazil/util/http/HttpUtil.java:300: date = date.substring(0, 29);
On 2012/11/27 12:55:10, Wladimir Palant wrote:
> Ok, so the point here is removing +00:00 at the end. Ideally we would adjust
the
> format (remove "z" at the end and just add "GMT" ourselves) but parseTime()
> below makes that hard. So maybe just look for the last occurrence of "+" in
the
> result and truncate to that point if you find it.

Done.

http://codereview.adblockplus.org/8961044/diff/1/src/sunlabs/brazil/util/http...
src/sunlabs/brazil/util/http/HttpUtil.java:301: return date;
On 2012/11/27 11:59:17, Wladimir Palant wrote:
> Indentation seems to be messed up here - you should either use tabs as the
> original code (preferred) or replace all the tabs by spaces in a separate
commit
> first.

I will fix it before commit in vi.

[Wladimir Palant, 2012-11-27 13:14:37]

LGTM