Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 9043026: Adapted private browsing handling to per-window private browsing in Firefox 20 (Closed)

Created:
Dec. 18, 2012, 2:35 p.m. by Wladimir Palant
Modified:
Dec. 19, 2012, 2:42 p.m.
Reviewers:
Thomas Greiner
Visibility:
Public.

Description

Adapted private browsing handling to per-window private browsing in Firefox 20

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -14 lines) Patch
M chrome/content/ui/sendReport.js View 6 chunks +8 lines, -7 lines 0 comments Download
M lib/contentPolicy.js View 4 chunks +4 lines, -4 lines 0 comments Download
M lib/filterStorage.js View 1 2 2 chunks +28 lines, -3 lines 0 comments Download

Messages

Total messages: 5
Wladimir Palant
Dec. 18, 2012, 2:35 p.m. (2012-12-18 14:35:32 UTC) #1
Wladimir Palant
I uploaded a new patch, the previous one caused us to constantly report NO_INTERFACE error ...
Dec. 18, 2012, 2:58 p.m. (2012-12-18 14:58:04 UTC) #2
Thomas Greiner
http://codereview.adblockplus.org/9043026/diff/2001/lib/filterStorage.js File lib/filterStorage.js (right): http://codereview.adblockplus.org/9043026/diff/2001/lib/filterStorage.js#newcode738 lib/filterStorage.js:738: // Gecko 19 and below will throw NO_INTERFACE, this ...
Dec. 19, 2012, 2:21 p.m. (2012-12-19 14:21:39 UTC) #3
Wladimir Palant
Fair enough, updated the patch.
Dec. 19, 2012, 2:35 p.m. (2012-12-19 14:35:24 UTC) #4
Thomas Greiner
Dec. 19, 2012, 2:37 p.m. (2012-12-19 14:37:43 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld