Nightly builds: prepared for the change in the Chrome build process

Two revisions here: one makes sure to get the subrepositories in |hg archive|, the other updates metadata processing

[Wladimir Palant, 2013-01-02 07:37:28]

As discussed on IRC, I am using hg clone instead of hg archive to work around
http://bz.selenic.com/show_bug.cgi?id=3747 - even though it will be a lot slower
now.

[Felix Dahlke, 2013-01-02 07:47:33]

http://codereview.adblockplus.org/9044061/diff/5001/sitescripts/extensions/bi...
File sitescripts/extensions/bin/createNightlies.py (right):

http://codereview.adblockplus.org/9044061/diff/5001/sitescripts/extensions/bi...
sitescripts/extensions/bin/createNightlies.py:92: command = ['hg', 'clone',
'-q', self.config.repository, '-u', 'default', self.tempdir]
Are you sure "-u default" is necessary? Don't think so. Would also be
problematic for anwiki, which doesn't have a default branch (though it should
have one I think).

http://codereview.adblockplus.org/9044061/diff/5001/sitescripts/extensions/bi...
sitescripts/extensions/bin/createNightlies.py:160: import
buildtools.packagerChrome as packager
Shouldn't this be "buildtools.packagerPorts" or something now?

[Wladimir Palant, 2013-01-02 08:13:04]

http://codereview.adblockplus.org/9044061/diff/5001/sitescripts/extensions/bi...
File sitescripts/extensions/bin/createNightlies.py (right):

http://codereview.adblockplus.org/9044061/diff/5001/sitescripts/extensions/bi...
sitescripts/extensions/bin/createNightlies.py:92: command = ['hg', 'clone',
'-q', self.config.repository, '-u', 'default', self.tempdir]
Yes, it is absolutely necessary - otherwise Mercurial will update to tip which
might be on a random branch. We don't want to build changes that haven't been
merged to default.

If we ever decide to create Anwiki builds we should make sure that there is a
default branch there. Normally it should be present in any Mercurial repository
but Anwiki has been converted from SVN.

http://codereview.adblockplus.org/9044061/diff/5001/sitescripts/extensions/bi...
sitescripts/extensions/bin/createNightlies.py:160: import
buildtools.packagerChrome as packager
On 2013/01/02 07:47:33, Felix H. Dahlke wrote:
> Shouldn't this be "buildtools.packagerPorts" or something now?

No, not really. I doubt that we will ever have the same packager module for
Chrome and Opera even though the two packages might share some functions.

[Felix Dahlke, 2013-01-02 08:17:20]

LGTM

On 2013/01/02 08:13:04, Wladimir Palant wrote:
>
http://codereview.adblockplus.org/9044061/diff/5001/sitescripts/extensions/bi...
> File sitescripts/extensions/bin/createNightlies.py (right):
> 
>
http://codereview.adblockplus.org/9044061/diff/5001/sitescripts/extensions/bi...
> sitescripts/extensions/bin/createNightlies.py:92: command = ['hg', 'clone',
> '-q', self.config.repository, '-u', 'default', self.tempdir]
> Yes, it is absolutely necessary - otherwise Mercurial will update to tip which
> might be on a random branch.

Oh, wasn't aware of that, thought clone would always go for default, as git
seems to hard code master.

http://codereview.adblockplus.org/9044061/diff/5001/sitescripts/extensions/bi...
> sitescripts/extensions/bin/createNightlies.py:160: import
> buildtools.packagerChrome as packager
> On 2013/01/02 07:47:33, Felix H. Dahlke wrote:
> > Shouldn't this be "buildtools.packagerPorts" or something now?
> 
> No, not really. I doubt that we will ever have the same packager module for
> Chrome and Opera even though the two packages might share some functions.

I see.