Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 9084006: task.js: cooperative multitasking for long-running tasks (Closed)

Created:
Dec. 26, 2012, 5:06 p.m. by Eric
Modified:
June 12, 2013, 2:18 p.m.
Visibility:
Public.

Description

This is principally about task.js, which implements Long_Task, a class to run long-running tasks using a cooperative multitasking model. Other changes really just support this one. counter_task.js is a very simple task generator that counts up to a limit. It's a testing example more than anything. Similarly task_test_ui.js. crawler.xul got a tab set. NOTE: Because a defect, probably within IDEA, when I renamed crawler.js to crawler_ui.js (there were two files with the same name in different directories), it got committed to the repository as a file delete/add rather than a file rename. The hgreview extension proceeded to choke on this situation, aborting entirely rather than doing something sensible. Thus there are some very small initial changes missing from this changeset. This seemed better than not having a changeset at all.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+375 lines, -11 lines) Patch
M chrome/content/crawler.xul View 2 chunks +11 lines, -3 lines 0 comments Download
M chrome/content/crawler_ui.js View 1 chunk +7 lines, -5 lines 0 comments Download
M chrome/content/task_test_ui.js View 1 chunk +83 lines, -3 lines 0 comments Download
A lib/counter_task.js View 1 chunk +47 lines, -0 lines 0 comments Download
A lib/task.js View 1 chunk +227 lines, -0 lines 0 comments Download

Messages

Total messages: 2
Felix Dahlke
Says "Bad Content" for me, can't look at the code :( Is this something we ...
June 4, 2013, 2:11 p.m. (2013-06-04 14:11:09 UTC) #1
Eric
June 5, 2013, 6:04 p.m. (2013-06-05 18:04:05 UTC) #2
On 2013/06/04 14:11:09, Felix H. Dahlke wrote:
> Is this something we should review separately or shouldn't we just do it as
part
> of the big Crawler review?

No need to do it separately. It's not even the most recent version of the code
(although it's reasonably close).

I'll close this review, given that it's been superseded.

Powered by Google App Engine
This is Rietveld