Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 9148089: Less hacky implementation of the language selection (Closed)

Created:
Jan. 9, 2013, 1:15 p.m. by Wladimir Palant
Modified:
Jan. 9, 2013, 1:56 p.m.
Reviewers:
Felix Dahlke
Visibility:
Public.

Description

This is mostly moving code around and changing variable names to more readable variants. I changed the handling of linkStyle however to make sure we don`t insert unnecessary empty style attributes

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -90 lines) Patch
M anwiki/_override/actions/action_view/action_view.tpl.php View 1 1 chunk +0 lines, -74 lines 0 comments Download
M anwiki/_override/contentclasses/contentclass_menu/contentclass_menu.tpl.php View 1 2 1 chunk +88 lines, -0 lines 0 comments Download
M anwiki/_override/global/global/global.tpl.php View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 6
Wladimir Palant
Jan. 9, 2013, 1:15 p.m. (2013-01-09 13:15:43 UTC) #1
Felix Dahlke
http://codereview.adblockplus.org/9148089/diff/1/anwiki/_override/actions/action_view/action_view.tpl.php File anwiki/_override/actions/action_view/action_view.tpl.php (left): http://codereview.adblockplus.org/9148089/diff/1/anwiki/_override/actions/action_view/action_view.tpl.php#oldcode9 anwiki/_override/actions/action_view/action_view.tpl.php:9: {$this->pageTranslations($aoTranslations)} How about replacing this with {} and removing ...
Jan. 9, 2013, 1:20 p.m. (2013-01-09 13:20:26 UTC) #2
Wladimir Palant
http://codereview.adblockplus.org/9148089/diff/1/anwiki/_override/actions/action_view/action_view.tpl.php File anwiki/_override/actions/action_view/action_view.tpl.php (left): http://codereview.adblockplus.org/9148089/diff/1/anwiki/_override/actions/action_view/action_view.tpl.php#oldcode9 anwiki/_override/actions/action_view/action_view.tpl.php:9: {$this->pageTranslations($aoTranslations)} On 2013/01/09 13:20:26, Felix H. Dahlke wrote: > ...
Jan. 9, 2013, 1:32 p.m. (2013-01-09 13:32:12 UTC) #3
Felix Dahlke
LGTM
Jan. 9, 2013, 1:40 p.m. (2013-01-09 13:40:51 UTC) #4
Wladimir Palant
Still had to fix one more issue - forgot to check whether the page actually ...
Jan. 9, 2013, 1:55 p.m. (2013-01-09 13:55:12 UTC) #5
Felix Dahlke
Jan. 9, 2013, 1:56 p.m. (2013-01-09 13:56:01 UTC) #6
Didn't even notice that yet. LGTM again.

Powered by Google App Engine
This is Rietveld