Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 9169140: Bug 798567 removed nsIDOMCSSValueList interface (Closed)

Created:
Jan. 14, 2013, 12:52 p.m. by Wladimir Palant
Modified:
Jan. 14, 2013, 7:15 p.m.
Reviewers:
Thomas Greiner
Visibility:
Public.

Description

Bug 798567 removed nsIDOMCSSValueList interface

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M .hgsubstate View 1 chunk +1 line, -1 line 0 comments Download
M lib/ui.js View 1 chunk +4 lines, -2 lines 4 comments Download

Messages

Total messages: 4
Wladimir Palant
Jan. 14, 2013, 12:52 p.m. (2013-01-14 12:52:25 UTC) #1
Thomas Greiner
http://codereview.adblockplus.org/9169140/diff/1/lib/ui.js File lib/ui.js (right): http://codereview.adblockplus.org/9169140/diff/1/lib/ui.js#newcode1723 lib/ui.js:1723: if ("length" in value && value.length >= 1) What ...
Jan. 14, 2013, 2:16 p.m. (2013-01-14 14:16:24 UTC) #2
Wladimir Palant
http://codereview.adblockplus.org/9169140/diff/1/lib/ui.js File lib/ui.js (right): http://codereview.adblockplus.org/9169140/diff/1/lib/ui.js#newcode1723 lib/ui.js:1723: if ("length" in value && value.length >= 1) On ...
Jan. 14, 2013, 2:46 p.m. (2013-01-14 14:46:54 UTC) #3
Thomas Greiner
Jan. 14, 2013, 5:08 p.m. (2013-01-14 17:08:20 UTC) #4
I'd be happier if you could find a better way to check for that but I can't
think of any myself so LGTM

Powered by Google App Engine
This is Rietveld