Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 9170066: Don't use firefox as the default user agent (Closed)

Created:
Jan. 9, 2013, 3:13 p.m. by Felix Dahlke
Modified:
Nov. 8, 2013, 8:04 a.m.
Reviewers:
Wladimir Palant
CC:
Thomas Greiner
Visibility:
Public.

Description

Before these changes, Internet Explorer (and Safari etc.) would be recognised as firefox, because that was the default.

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M modules/adblockplusorg/files/adblockplus.org View 1 3 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 3
Felix Dahlke
Jan. 9, 2013, 3:18 p.m. (2013-01-09 15:18:23 UTC) #1
Wladimir Palant
LGTM with Firefox detection replaced by Gecko detection. http://codereview.adblockplus.org/9170066/diff/1/modules/adblockplusorg/files/adblockplus.org File modules/adblockplusorg/files/adblockplus.org (right): http://codereview.adblockplus.org/9170066/diff/1/modules/adblockplusorg/files/adblockplus.org#newcode20 modules/adblockplusorg/files/adblockplus.org:20: if ...
Jan. 9, 2013, 6:42 p.m. (2013-01-09 18:42:08 UTC) #2
Felix Dahlke
Jan. 10, 2013, 4:49 a.m. (2013-01-10 04:49:04 UTC) #3
Alright, fixed.

http://codereview.adblockplus.org/9170066/diff/1/modules/adblockplusorg/files...
File modules/adblockplusorg/files/adblockplus.org (right):

http://codereview.adblockplus.org/9170066/diff/1/modules/adblockplusorg/files...
modules/adblockplusorg/files/adblockplus.org:20: if ($http_user_agent ~
\bFirefox/\d+) {
On 2013/01/09 18:42:08, Wladimir Palant wrote:
> Not Firefox/\d+ but Gecko/d+ please.

Done.

Powered by Google App Engine
This is Rietveld