Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 9321092: Make sure nginx is properly restarted when the configuration changes (Closed)

Created:
Feb. 6, 2013, 9:50 a.m. by Wladimir Palant
Modified:
Nov. 8, 2013, 8:04 a.m.
Reviewers:
Andrey Novikov
Visibility:
Public.

Description

Make sure nginx is properly restarted when the configuration changes

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -16 lines) Patch
M modules/filterserver/manifests/init.pp View 1 chunk +5 lines, -5 lines 2 comments Download
M modules/nginx/manifests/init.pp View 2 chunks +2 lines, -11 lines 0 comments Download

Messages

Total messages: 4
Wladimir Palant
Feb. 6, 2013, 9:50 a.m. (2013-02-06 09:50:52 UTC) #1
Andrey Novikov
http://codereview.adblockplus.org/9321092/diff/1/modules/filterserver/manifests/init.pp File modules/filterserver/manifests/init.pp (right): http://codereview.adblockplus.org/9321092/diff/1/modules/filterserver/manifests/init.pp#newcode75 modules/filterserver/manifests/init.pp:75: notify => Service['nginx'], The point was to hide implementation ...
Feb. 6, 2013, 10:03 a.m. (2013-02-06 10:03:54 UTC) #2
Wladimir Palant
http://codereview.adblockplus.org/9321092/diff/1/modules/filterserver/manifests/init.pp File modules/filterserver/manifests/init.pp (right): http://codereview.adblockplus.org/9321092/diff/1/modules/filterserver/manifests/init.pp#newcode75 modules/filterserver/manifests/init.pp:75: notify => Service['nginx'], ~> is just an alternative syntax ...
Feb. 6, 2013, 10:42 a.m. (2013-02-06 10:42:31 UTC) #3
Andrey Novikov
Feb. 6, 2013, 11 a.m. (2013-02-06 11:00:39 UTC) #4
LGTM then

Powered by Google App Engine
This is Rietveld