Make sure nginx is properly restarted when the configuration changes

modules/filterserver/manifests/init.pp

Index: modules/filterserver/manifests/init.pp
===================================================================
--- a/modules/filterserver/manifests/init.pp
+++ b/modules/filterserver/manifests/init.pp
@@ -67,45 +67,45 @@ class filterserver {
 
   file {'/var/www/subscriptionStats.ini':
     ensure => present,
     owner => rsync
   }
 
   file {'/etc/nginx/sites-available/inc.easylist-downloads':
     ensure => file,
-    require => Anchor['nginx::end'],
+    notify => Service['nginx'],

[Andrey Novikov, 2013/02/06 10:03:54]

The point was to hide implementation from other modules. May be it would better
to use '~>' notation and leave anchors?
http://docs.puppetlabs.com/puppet/3/reference/lang_relationships.html#chainin...

[Wladimir Palant, 2013/02/06 10:42:31]

~> is just an alternative syntax for "notify => ", one that we don't use
anywhere. It's pointless if the anchor won't notify services (most likely
because nothing changes for that anchor). I tried a few things but none worked -
so let's go with the simple solution that solves the immediate issue and stop
wasting time. In the long term Felix wants to refactor the way sites are
defined, then the necessity to trigger nginx service outside the nginx module
will go away.

     before => Nginx::Hostconfig['easylist-downloads.adblockplus.org'],
     source => 'puppet:///modules/filterserver/inc.easylist-downloads'
   }
 
   file {'/etc/nginx/sites-available/inc.easylist-downloads-txt':
     ensure => file,
-    require => Anchor['nginx::end'],
+    notify => Service['nginx'],
     before => Nginx::Hostconfig['easylist-downloads.adblockplus.org'],
     source => 'puppet:///modules/filterserver/inc.easylist-downloads-txt'
   }
 
   file {'/etc/nginx/sites-available/inc.easylist-downloads-tpl':
     ensure => file,
-    require => Anchor['nginx::end'],
+    notify => Service['nginx'],
     before => Nginx::Hostconfig['easylist-downloads.adblockplus.org'],
     source => 'puppet:///modules/filterserver/inc.easylist-downloads-tpl'
   }
 
   file {'/etc/nginx/sites-available/easylist-downloads.adblockplus.org_sslcert.key':
     ensure => file,
-    require => Anchor['nginx::end'],
+    notify => Service['nginx'],
     before => Nginx::Hostconfig['easylist-downloads.adblockplus.org'],
     source => 'puppet:///modules/private/easylist-downloads.adblockplus.org_sslcert.key'
   }
 
   file {'/etc/nginx/sites-available/easylist-downloads.adblockplus.org_sslcert.pem':
     ensure => file,
-    require => Anchor['nginx::end'],
+    notify => Service['nginx'],
     before => Nginx::Hostconfig['easylist-downloads.adblockplus.org'],
     mode => 0400,
     source => 'puppet:///modules/private/easylist-downloads.adblockplus.org_sslcert.pem'
   }
 
   nginx::hostconfig{'easylist-downloads.adblockplus.org':
     source => 'puppet:///modules/filterserver/easylist-downloads.adblockplus.org',
     enabled => true