Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 9343001: Add Postfix configuration to the repository, make Postfix listen onlocal interfaces only (Closed)

Created:
Feb. 6, 2013, 8:19 a.m. by Wladimir Palant
Modified:
Nov. 8, 2013, 8:04 a.m.
Reviewers:
Felix Dahlke
Visibility:
Public.

Description

Add Postfix configuration to the repository, make Postfix listen on local interfaces only

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -2 lines) Patch
M modules/base/manifests/init.pp View 1 1 chunk +2 lines, -2 lines 0 comments Download
A modules/postfix/files/main.cf View 1 chunk +38 lines, -0 lines 0 comments Download
A modules/postfix/manifests/init.pp View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Wladimir Palant
Feb. 6, 2013, 8:20 a.m. (2013-02-06 08:20:17 UTC) #1
Felix Dahlke
http://codereview.adblockplus.org/9343001/diff/1/manifests/filterserver.pp File manifests/filterserver.pp (right): http://codereview.adblockplus.org/9343001/diff/1/manifests/filterserver.pp#newcode2 manifests/filterserver.pp:2: include base, postfix, filterserver Shouldn't we include postfix in ...
Feb. 6, 2013, 9:17 a.m. (2013-02-06 09:17:57 UTC) #2
Wladimir Palant
http://codereview.adblockplus.org/9343001/diff/1/manifests/filterserver.pp File manifests/filterserver.pp (right): http://codereview.adblockplus.org/9343001/diff/1/manifests/filterserver.pp#newcode2 manifests/filterserver.pp:2: include base, postfix, filterserver On 2013/02/06 09:17:58, Felix H. ...
Feb. 6, 2013, 9:58 a.m. (2013-02-06 09:58:39 UTC) #3
Felix Dahlke
Feb. 6, 2013, 10:02 a.m. (2013-02-06 10:02:06 UTC) #4
LGTM

http://codereview.adblockplus.org/9343001/diff/1/manifests/filterserver.pp
File manifests/filterserver.pp (right):

http://codereview.adblockplus.org/9343001/diff/1/manifests/filterserver.pp#ne...
manifests/filterserver.pp:2: include base, postfix, filterserver
On 2013/02/06 09:58:39, Wladimir Palant wrote:
> On 2013/02/06 09:17:58, Felix H. Dahlke wrote:
> > Shouldn't we include postfix in base? We need it on every system to send
cron
> > mails, and every system has cron jobs of whose failures we want to be
> informed.
> 
> Same is true for SSH - but whatever :)

Yes, but the problem with SSH is that it has an optional parameter that some
nodes set, others not, and we can't include it twice.

Powered by Google App Engine
This is Rietveld