Issue 9349198: Properly return WARNING and CRITICAL in check_bandwidth

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9349198: Properly return WARNING and CRITICAL in check_bandwidth (Closed)

Created:
Feb. 19, 2013, 2:08 p.m. by Felix Dahlke

Modified:
Nov. 8, 2013, 8:06 a.m.

Reviewers:
Wladimir Palant

Visibility:
Public.

Description

This is why we're not receiving notifications about warning/critical bandwidth levels. I fixed various issues here: - Convert warn/crit to int - Don't show WARNING when it's CRITICAL I'm also now checking for rx >= warn, not the weird warn <= rx I inherited from the bash script I was basing this on.

Patch Set 1 #

Patch Set 2 : Fixed usage #

Created: Feb. 19, 2013, 2:14 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -7 lines)			Patch
	M	modules/nagios/files/check_bandwidth	View	1	3 chunks	+10 lines, -7 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Felix Dahlke

Now I've also fixed the usage. Not great to stuff it all into one issue, ...

Feb. 19, 2013, 2:15 p.m. (2013-02-19 14:15:47 UTC) #2

LGTM

Expand All Messages | Collapse All Messages