Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 9351210: Define Discourse admins and site settings in Puppet, separate private data from other settings (Closed)

Created:
Feb. 19, 2013, 3:08 p.m. by Wladimir Palant
Modified:
Nov. 8, 2013, 8:05 a.m.
Reviewers:
Felix Dahlke
Visibility:
Public.

Description

Define Discourse admins and site settings in Puppet, separate private data from other settings

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -7 lines) Patch
M Vagrantfile View 1 chunk +3 lines, -1 line 0 comments Download
M modules/discourse/files/init-discourse View 2 chunks +8 lines, -5 lines 0 comments Download
A modules/discourse/manifests/admin.pp View 1 chunk +28 lines, -0 lines 0 comments Download
M modules/discourse/manifests/init.pp View 3 chunks +42 lines, -1 line 1 comment Download
A modules/discourse/manifests/sitesetting.pp View 1 chunk +36 lines, -0 lines 1 comment Download
A modules/private-stub/manifests/discourse.pp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Wladimir Palant
Feb. 19, 2013, 3:08 p.m. (2013-02-19 15:08:21 UTC) #1
Felix Dahlke
LGTM, feel free to address my comment. http://codereview.adblockplus.org/9351210/diff/1/modules/discourse/manifests/init.pp File modules/discourse/manifests/init.pp (right): http://codereview.adblockplus.org/9351210/diff/1/modules/discourse/manifests/init.pp#newcode120 modules/discourse/manifests/init.pp:120: discourse::sitesetting {'title': ...
Feb. 21, 2013, 3:27 p.m. (2013-02-21 15:27:40 UTC) #2
Felix Dahlke
On 2013/02/21 15:27:40, Felix H. Dahlke wrote: > LGTM, feel free to address my comment. ...
Feb. 21, 2013, 3:28 p.m. (2013-02-21 15:28:22 UTC) #3
Wladimir Palant
Feb. 21, 2013, 4:37 p.m. (2013-02-21 16:37:16 UTC) #4
On 2013/02/21 15:28:22, Felix H. Dahlke wrote:
> Actually: "Feel free to address my comment or not." :)

I felt free to address it :)

Powered by Google App Engine
This is Rietveld