modules/discourse/files/discourse.fcgi - Issue 9377123: Set up proper FastCGI environment for Discourse and use nginx

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: modules/discourse/files/discourse.fcgi

Issue 9377123: Set up proper FastCGI environment for Discourse and use nginx (Closed)

Left Patch Set: Converted init_discourse script to Python Created Feb. 18, 2013, 2:03 p.m.

Right Patch Set: Cleaner definition of the environment variables Created Feb. 22, 2013, 1:51 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 #!/usr/bin/ruby	1 #!/usr/bin/ruby

	2

	3 require 'etc'

2	4

3 Dir.chdir(File.dirname(__FILE__))	5 Dir.chdir(File.dirname(__FILE__))

4 ENV['RAILS_ENV'] \|\|= 'production'	6 ENV['RAILS_ENV'] \|\|= 'production'

5 ENV['GEM_HOME'] = File.expand_path('~discourse/.gems')	7 ENV['GEM_HOME'] = "#{Etc.getpwuid.dir}/.gems"

6 ENV['GEM_PATH'] = File.expand_path('~discourse/.gems') + ':/var/lib/gems/1.9.1'	8 ENV['GEM_PATH'] = "#{ENV['GEM_HOME']}:/var/lib/gems/1.9.1"
Felix Dahlke 2013/02/21 15:56:02 How about ENV['GEM_HOME'] + ':/var/lib/gems/1.9.1' How about ENV['GEM_HOME'] + ':/var/lib/gems/1.9.1'? Wladimir Palant 2013/02/22 13:52:54 Done that and also got rid of the hardcoded user n Show quoted text On 2013/02/21 15:56:02, Felix H. Dahlke wrote: > How about ENV['GEM_HOME'] + ':/var/lib/gems/1.9.1'? Done that and also got rid of the hardcoded user name here. Now somebody needs to figure out how to get the default GEM_PATH so that we don't need to hardcode /var/lib/gems/1.9.1 here :) Felix Dahlke 2013/02/22 13:56:01 That should do: gem env gemdir Show quoted text On 2013/02/22 13:52:54, Wladimir Palant wrote: > On 2013/02/21 15:56:02, Felix H. Dahlke wrote: > > How about ENV['GEM_HOME'] + ':/var/lib/gems/1.9.1'? > > Done that and also got rid of the hardcoded user name here. Now somebody needs > to figure out how to get the default GEM_PATH so that we don't need to hardcode > /var/lib/gems/1.9.1 here :) That should do: gem env gemdir Wladimir Palant 2013/02/22 13:59:34 And now from inside Ruby please, without starting Show quoted text On 2013/02/22 13:56:01, Felix H. Dahlke wrote: > That should do: > > gem env gemdir And now from inside Ruby please, without starting command line tools :) Wladimir Palant 2013/02/27 17:03:02 Now that we are no longer using FCGI this should b Now that we are no longer using FCGI this should be irrelevant. Any other issues left here?
7	9

8 require 'fcgi'	10 require 'fcgi'

9 require_relative 'config/environment'	11 require_relative 'config/environment'

10	12

11 class Rack::PathInfoRewriter	13 class Rack::PathInfoRewriter

12 def initialize(app)	14 def initialize(app)

13 @app = app	15 @app = app

14 end	16 end

15	17

16 def call(env)	18 def call(env)

17 env.delete('SCRIPT_NAME')	19 env.delete('SCRIPT_NAME')

18 parts = env['REQUEST_URI'].split('?')	20 parts = env['REQUEST_URI'].split('?')

19 env['PATH_INFO'] = parts[0]	21 env['PATH_INFO'] = parts[0]

20 env['QUERY_STRING'] = parts[1].to_s	22 env['QUERY_STRING'] = parts[1].to_s

21 @app.call(env)	23 @app.call(env)

22 end	24 end

23 end	25 end

24	26

25 Rack::Handler::FastCGI.run Rack::PathInfoRewriter.new(Discourse::Application)	27 Rack::Handler::FastCGI.run Rack::PathInfoRewriter.new(Discourse::Application)

LEFT	RIGHT