Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 9377123: Set up proper FastCGI environment for Discourse and use nginx (Closed)

Created:
Feb. 15, 2013, 9:29 p.m. by Wladimir Palant
Modified:
Nov. 8, 2013, 8:06 a.m.
Reviewers:
Felix Dahlke
Visibility:
Public.

Description

There is still some error message at the end of init-discourse run and the way I modify Gemfile is rather hacky (a separate second Gemfile didn`t work out) but it seems to work now.

Patch Set 1 #

Patch Set 2 : Installing gems per user again #

Patch Set 3 : Converted init_discourse script to Python #

Total comments: 6

Patch Set 4 : Cleaner definition of the environment variables #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M modules/discourse/files/discourse.fcgi View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 9
Wladimir Palant
Feb. 15, 2013, 9:29 p.m. (2013-02-15 21:29:21 UTC) #1
Wladimir Palant
I switched to per-user installation again - the issue I was trying to solve turned ...
Feb. 16, 2013, 8:36 a.m. (2013-02-16 08:36:18 UTC) #2
Wladimir Palant
The init-discourse is now written in Python so that it can manipulate Gemfile and secret_token.rb ...
Feb. 18, 2013, 2:08 p.m. (2013-02-18 14:08:07 UTC) #3
Felix Dahlke
http://codereview.adblockplus.org/9377123/diff/5001/modules/discourse/files/discourse.fcgi File modules/discourse/files/discourse.fcgi (right): http://codereview.adblockplus.org/9377123/diff/5001/modules/discourse/files/discourse.fcgi#newcode6 modules/discourse/files/discourse.fcgi:6: ENV['GEM_PATH'] = File.expand_path('~discourse/.gems') + ':/var/lib/gems/1.9.1' How about ENV['GEM_HOME'] + ...
Feb. 21, 2013, 3:56 p.m. (2013-02-21 15:56:02 UTC) #4
Wladimir Palant
http://codereview.adblockplus.org/9377123/diff/5001/modules/discourse/files/discourse.fcgi File modules/discourse/files/discourse.fcgi (right): http://codereview.adblockplus.org/9377123/diff/5001/modules/discourse/files/discourse.fcgi#newcode6 modules/discourse/files/discourse.fcgi:6: ENV['GEM_PATH'] = File.expand_path('~discourse/.gems') + ':/var/lib/gems/1.9.1' On 2013/02/21 15:56:02, Felix ...
Feb. 22, 2013, 1:52 p.m. (2013-02-22 13:52:54 UTC) #5
Felix Dahlke
http://codereview.adblockplus.org/9377123/diff/5001/modules/discourse/files/discourse.fcgi File modules/discourse/files/discourse.fcgi (right): http://codereview.adblockplus.org/9377123/diff/5001/modules/discourse/files/discourse.fcgi#newcode6 modules/discourse/files/discourse.fcgi:6: ENV['GEM_PATH'] = File.expand_path('~discourse/.gems') + ':/var/lib/gems/1.9.1' On 2013/02/22 13:52:54, Wladimir ...
Feb. 22, 2013, 1:56 p.m. (2013-02-22 13:56:01 UTC) #6
Wladimir Palant
http://codereview.adblockplus.org/9377123/diff/5001/modules/discourse/files/discourse.fcgi File modules/discourse/files/discourse.fcgi (right): http://codereview.adblockplus.org/9377123/diff/5001/modules/discourse/files/discourse.fcgi#newcode6 modules/discourse/files/discourse.fcgi:6: ENV['GEM_PATH'] = File.expand_path('~discourse/.gems') + ':/var/lib/gems/1.9.1' On 2013/02/22 13:56:01, Felix ...
Feb. 22, 2013, 1:59 p.m. (2013-02-22 13:59:34 UTC) #7
Wladimir Palant
http://codereview.adblockplus.org/9377123/diff/5001/modules/discourse/files/discourse.fcgi File modules/discourse/files/discourse.fcgi (right): http://codereview.adblockplus.org/9377123/diff/5001/modules/discourse/files/discourse.fcgi#newcode6 modules/discourse/files/discourse.fcgi:6: ENV['GEM_PATH'] = File.expand_path('~discourse/.gems') + ':/var/lib/gems/1.9.1' Now that we are ...
Feb. 27, 2013, 5:03 p.m. (2013-02-27 17:03:02 UTC) #8
Felix Dahlke
Feb. 28, 2013, 12:43 p.m. (2013-02-28 12:43:42 UTC) #9
LGTM

Powered by Google App Engine
This is Rietveld