Issue 9423010: ABP/Android Better icon hide

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9423010: ABP/Android Better icon hide (Closed)

Created:
Feb. 20, 2013, 12:08 p.m. by Andrey Novikov

Modified:
Jan. 4, 2016, 12:35 p.m.

Reviewers:
Thomas Greiner

Visibility:
Public.

Description

ABP/Android Better icon hide

Patch Set 1 #

Total comments: 7

Created: Feb. 20, 2013, 12:08 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+125 lines, -58 lines)			Patch
M	res/values/strings.xml	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/org/adblockplus/android/AdblockPlus.java	View	12 chunks	+37 lines, -9 lines	1 comment	Download
M	src/org/adblockplus/android/Preferences.java	View	2 chunks	+21 lines, -2 lines	1 comment	Download
M	src/org/adblockplus/android/ProxyService.java	View	9 chunks	+65 lines, -46 lines	4 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Thomas Greiner

Feb. 27, 2013, 4:34 p.m. (2013-02-27 16:34:29 UTC) #2

only minor changes :)

http://codereview.adblockplus.org/9423010/diff/1/src/org/adblockplus/android/...
File src/org/adblockplus/android/AdblockPlus.java (right):

http://codereview.adblockplus.org/9423010/diff/1/src/org/adblockplus/android/...
src/org/adblockplus/android/AdblockPlus.java:256: *
How did that happen? I noticed that there are 8 occurences of such trailing
whitespace that were added in this commit.

http://codereview.adblockplus.org/9423010/diff/1/src/org/adblockplus/android/...
File src/org/adblockplus/android/Preferences.java (right):

http://codereview.adblockplus.org/9423010/diff/1/src/org/adblockplus/android/...
src/org/adblockplus/android/Preferences.java:359: {
mind the indentation level

http://codereview.adblockplus.org/9423010/diff/1/src/org/adblockplus/android/...
src/org/adblockplus/android/Preferences.java:370: {
mind the indentation level

http://codereview.adblockplus.org/9423010/diff/1/src/org/adblockplus/android/...
File src/org/adblockplus/android/ProxyService.java (right):

http://codereview.adblockplus.org/9423010/diff/1/src/org/adblockplus/android/...
src/org/adblockplus/android/ProxyService.java:616: if (ourProxy !=
proxyManualyConfigured)
rename to proxyManuallyConfigured

http://codereview.adblockplus.org/9423010/diff/1/src/org/adblockplus/android/...
src/org/adblockplus/android/ProxyService.java:628: notrafficHandler = new
Handler();
variable name should be camel-cased (otherwise it is inconsistent with
stopNoTrafficCheck and updateNoTrafficCheck)

http://codereview.adblockplus.org/9423010/diff/1/src/org/adblockplus/android/...
src/org/adblockplus/android/ProxyService.java:659: Log.e(TAG, "V: " +
nativeProxy + " " + proxyManualyConfigured + " " + transparent);
Why is this being logged with priority ERROR?

http://codereview.adblockplus.org/9423010/diff/1/src/org/adblockplus/android/...
src/org/adblockplus/android/ProxyService.java:665: //builder.setContent(new
RemoteViews(getPackageName(), R.layout.notif_hidden));
you can add a TODO here but keep unused code in local repo

Expand All Messages | Collapse All Messages