Issue 9432188: Configure secret_token (assuming it`s actually used anywhere) and document other private settings

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9432188: Configure secret_token (assuming it`s actually used anywhere) and document other private settings (Closed)

Created:
Feb. 28, 2013, 11:13 a.m. by Wladimir Palant

Modified:
Nov. 8, 2013, 8:06 a.m.

Reviewers:
Felix Dahlke

Visibility:
Public.

Description

Configure secret_token (assuming it`s actually used anywhere) and document other private settings

Patch Set 1 #

Total comments: 2

Created: Feb. 28, 2013, 11:13 a.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -5 lines)			Patch
M	modules/base/manifests/init.pp	View	1 chunk	+4 lines, -4 lines	2 comments	Download
M	modules/discourse/manifests/init.pp	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	modules/private-stub/manifests/discourse.pp	View	1 chunk	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Felix Dahlke

LGTM if that change to the base module isn't part fo this http://codereview.adblockplus.org/9432188/diff/1/modules/base/manifests/init.pp File modules/base/manifests/init.pp ...

Feb. 28, 2013, 11:18 a.m. (2013-02-28 11:18:20 UTC) #2

Wladimir Palant

Feb. 28, 2013, 11:36 a.m. (2013-02-28 11:36:37 UTC) #3

http://codereview.adblockplus.org/9432188/diff/1/modules/base/manifests/init.pp
File modules/base/manifests/init.pp (right):

http://codereview.adblockplus.org/9432188/diff/1/modules/base/manifests/init....
modules/base/manifests/init.pp:5: #  class {'apt':
No, this isn't part of the commit - but I mistakenly added it back before
creating the review. Oops :)

You are correct, this is about turnaround times. apt update takes a while,
especially on a bad connection.

Expand All Messages | Collapse All Messages