Issue 9496013: Pop-up blocking functionality for Chrome

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9496013: Pop-up blocking functionality for Chrome (Closed)

Created:
March 1, 2013, 3:45 p.m. by Wladimir Palant

Modified:
March 5, 2013, 2:41 p.m.

Reviewers:
Thomas Greiner

Visibility:
Public.

Description

This tries to reproduce the pop-up blocking behavior for Firefox - first we check whether about:blank is allowed to be opened, then whether the actual target URL is allowed.

Patch Set 2 : Fixed wrong return statement #

Patch Set 3 : Use webNavigation API rather than tabs API (see issue 13021) #

Created: March 5, 2013, 12:14 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -17 lines)			Patch
	M	metadata.chrome	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
	M	popupBlocker.js	View	1 2	1 chunk	+11 lines, -17 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Thomas Greiner

LGTM, only a cosmetic change http://codereview.adblockplus.org/9496013/diff/1/popupBlocker.js File popupBlocker.js (right): http://codereview.adblockplus.org/9496013/diff/1/popupBlocker.js#newcode29 popupBlocker.js:29: return false; inconsistent with ...

March 4, 2013, 11:28 a.m. (2013-03-04 11:28:02 UTC) #2

LGTM

Expand All Messages | Collapse All Messages