Subscription stats: Make sure there can be no division by zero errors

Subscription stats: Make sure there can be no division by zero errors

[Wladimir Palant, 2013-03-01 08:30:34]

Found more places where divide-by-zero needs to be avoided.

[Felix Dahlke, 2013-03-01 08:53:05]

Wouldn't it be better to handle maxHits etc. being 0 as a special case? Doesn't
seem like reasonable data to me.

[Wladimir Palant, 2013-03-01 09:03:55]

On 2013/03/01 08:53:05, Felix H. Dahlke wrote:
> Wouldn't it be better to handle maxHits etc. being 0 as a special case?
Doesn't
> seem like reasonable data to me.

maxHits and totalHits can only be zero if all the individual hit counts are zero
- so the result of the division will still be zero. Handling it this way is
simpler than adding special cases everywhere that division is made (I actually
tried that first).

[Felix Dahlke, 2013-03-01 09:07:21]

On 2013/03/01 09:03:55, Wladimir Palant wrote:
> maxHits and totalHits can only be zero if all the individual hit counts are
zero
> - so the result of the division will still be zero. Handling it this way is
> simpler than adding special cases everywhere that division is made (I actually
> tried that first).

Right, LGTM.