Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 9752046: Add automatic updates for release builds (Closed)

Created:
March 14, 2013, 10:25 a.m. by Felix Dahlke
Modified:
March 15, 2013, 2:18 p.m.
Visibility:
Public.

Description

It's a bit difficult to test, but seems to work fine. The issue is that we don't seem to have permission to write to external storage when deploying via adb (i.e. Eclipse). Any idea how to fix that Andrey?

Patch Set 1 : #

Patch Set 2 : Request WRITE_EXTERNAL_STORAGE permission for release builds as well #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M AndroidManifest.xml View 1 1 chunk +1 line, -0 lines 0 comments Download
M res/values/sysstrings.xml View 1 chunk +2 lines, -1 line 0 comments Download
M src/org/adblockplus/android/AdblockPlus.java View 1 chunk +2 lines, -5 lines 0 comments Download
M src/org/adblockplus/android/updater/AlarmReceiver.java View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6
Felix Dahlke
March 14, 2013, 10:28 a.m. (2013-03-14 10:28:05 UTC) #1
Wladimir Palant
Wrong revision it seems, that's https://hg.adblockplus.org/adblockplusandroid/rev/f8e84b83ee60 rather than https://hg.adblockplus.org/adblockplusandroid/rev/16b20dc9bc11.
March 14, 2013, 10:31 a.m. (2013-03-14 10:31:03 UTC) #2
Felix Dahlke
On 2013/03/14 10:31:03, Wladimir Palant wrote: > Wrong revision it seems, that's > https://hg.adblockplus.org/adblockplusandroid/rev/f8e84b83ee60 rather ...
March 14, 2013, 10:41 a.m. (2013-03-14 10:41:20 UTC) #3
Wladimir Palant
LGTM but Andrey has the final word of course.
March 14, 2013, 10:43 a.m. (2013-03-14 10:43:09 UTC) #4
Andrey Novikov
You have to permanently add WRITE_EXTERNAL_STORAGE permission to Manifest, then LGTM.
March 15, 2013, 7:16 a.m. (2013-03-15 07:16:04 UTC) #5
Felix Dahlke
March 15, 2013, 8:06 a.m. (2013-03-15 08:06:12 UTC) #6
On 2013/03/15 07:16:04, Andrey Novikov wrote:
> You have to permanently add WRITE_EXTERNAL_STORAGE permission to Manifest

Done.

Powered by Google App Engine
This is Rietveld