Add file name and line number when reporting exceptions

include/AdblockPlus/JsEngine.h

 #ifndef ADBLOCKPLUS_JS_ENGINE_H
 #define ADBLOCKPLUS_JS_ENGINE_H
 
 #include <stdexcept>
 #include <string>
 #include <v8.h>
 
 class ErrorCallback;
 class FileReader;
 
 namespace AdblockPlus
 {
   class JsError : public std::runtime_error
   {
   public:
     JsError(const v8::Handle<v8::Value> exception,
-        const v8::Handle<v8::Message> message);
-  private:

[Felix Dahlke, 2013/03/15 14:18:15]

Mind adding an empty line before private? I know, pedantic :)

-    std::string toString(const v8::Handle<v8::Value> exception,

[Felix Dahlke, 2013/03/15 14:18:15]

We are starting all function/method names with an uppercase letter so far,
following the Mozilla conventions.

Since this method does not access any members, I'd just use a free function in
the unnamed namespace in JsEngine.cpp instead. But it's up to you of course.

[Wladimir Palant, 2013/03/15 15:27:26]

I prefer having this a method for reasons of better grouping, no reason to
pollute global namespace. I made it static however, it doesn't need a class
instance indeed.

         const v8::Handle<v8::Message> message);
   };
 
   class JsEngine
   {
   public:
     JsEngine(const FileReader* const fileReader,
              ErrorCallback* const errorCallback);
     void Evaluate(const char* source, const char* filename = NULL);
     void Evaluate(const std::string& source)
     {
       Evaluate(source.c_str());
     }
     void Evaluate(const std::string& source, const std::string& filename)
     {
       Evaluate(filename.c_str(), source.c_str());
     }
     void Load(const std::string& scriptPath);
     std::string Call(const std::string& functionName);
     void Gc();
 
   private:
     const FileReader* const fileReader;
     v8::Persistent<v8::Context> context;
     inline v8::Handle<v8::Script> CompileScript(const char* source, const char* filename);
   };
 }
 
 #endif