Add file name and line number when reporting exceptions

Add file name and line number when reporting exceptions

[Felix Dahlke, 2013-03-15 14:18:15]

http://codereview.adblockplus.org/9884006/diff/1/include/AdblockPlus/JsEngine.h
File include/AdblockPlus/JsEngine.h (right):

http://codereview.adblockplus.org/9884006/diff/1/include/AdblockPlus/JsEngine...
include/AdblockPlus/JsEngine.h:18: private:
Mind adding an empty line before private? I know, pedantic :)

http://codereview.adblockplus.org/9884006/diff/1/include/AdblockPlus/JsEngine...
include/AdblockPlus/JsEngine.h:19: std::string toString(const
v8::Handle<v8::Value> exception,
We are starting all function/method names with an uppercase letter so far,
following the Mozilla conventions.

Since this method does not access any members, I'd just use a free function in
the unnamed namespace in JsEngine.cpp instead. But it's up to you of course.

[Wladimir Palant, 2013-03-15 15:27:26]

http://codereview.adblockplus.org/9884006/diff/1/include/AdblockPlus/JsEngine.h
File include/AdblockPlus/JsEngine.h (right):

http://codereview.adblockplus.org/9884006/diff/1/include/AdblockPlus/JsEngine...
include/AdblockPlus/JsEngine.h:19: std::string toString(const
v8::Handle<v8::Value> exception,
On 2013/03/15 14:18:15, Felix H. Dahlke wrote:
> Since this method does not access any members, I'd just use a free function in
> the unnamed namespace in JsEngine.cpp instead. But it's up to you of course.

I prefer having this a method for reasons of better grouping, no reason to
pollute global namespace. I made it static however, it doesn't need a class
instance indeed.

[Felix Dahlke, 2013-03-15 15:29:54]

On 2013/03/15 15:27:26, Wladimir Palant wrote:
>
http://codereview.adblockplus.org/9884006/diff/1/include/AdblockPlus/JsEngine.h
> File include/AdblockPlus/JsEngine.h (right):
> 
>
http://codereview.adblockplus.org/9884006/diff/1/include/AdblockPlus/JsEngine...
> include/AdblockPlus/JsEngine.h:19: std::string toString(const
> v8::Handle<v8::Value> exception,
> On 2013/03/15 14:18:15, Felix H. Dahlke wrote:
> > Since this method does not access any members, I'd just use a free function
in
> > the unnamed namespace in JsEngine.cpp instead. But it's up to you of course.
> 
> I prefer having this a method for reasons of better grouping, no reason to
> pollute global namespace. I made it static however, it doesn't need a class
> instance indeed.

You're not polluting the global namespace if you put it into an unnamed
namespace. Anyway, LGTM.

[Felix Dahlke, 2013-03-15 15:41:43]

Even more LGTM :)